-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add --all-platforms
flag to bundle binstubs
to generate binstubs for all platforms
#3886
Add --all-platforms
flag to bundle binstubs
to generate binstubs for all platforms
#3886
Conversation
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
3b4e9f5
to
8b1f655
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @SeekingMeaning! I didn't review this because I thought it needed work due to some specs being broken. But now I looked at the failing specs and I'm not 100% sure they failures are related to this PR. They seem to break only on Windows, so that might indicate a relationship, but still I'm not fully sure.
Could you rebase and force-push this PR just to make sure?
And thanks for this, by the way! 😃 |
83222fd
to
03c21c4
Compare
@SeekingMeaning This looks good, but could you add some tests for it? |
Would adding this to it "allows installing binstubs for all platforms" do
install_gemfile <<-G
source "#{file_uri_for(gem_repo1)}"
gem "rack"
G
bundle "binstubs rack --all-platforms"
expect(bundled_app("bin/rackup")).to exist
expect(bundled_app("bin/rackup.cmd")).to exist
end |
That seems enough to me, yeah 👍. But since there's two different places where we're adding the check for the new option to generate the extra binstubs, I'd add a separate spec that covers the remaining place (I think you need to also run |
@SeekingMeaning This looks great to me, thanks! Could you rebase on top of latest master and squash both commits into one? |
1b4f7a2
to
7d9725f
Compare
--all-platforms
flag to bundle binstubs
to generate binstubs for all platforms
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks so much @SeekingMeaning!! 💜
Add `--all-platforms` flag to `bundle binstubs` to generate binstubs for all platforms (cherry picked from commit ba09c54)
Add `--all-platforms` flag to `bundle binstubs` to generate binstubs for all platforms (cherry picked from commit ba09c54)
Add `--all-platforms` flag to `bundle binstubs` to generate binstubs for all platforms (cherry picked from commit ba09c54)
Add `--all-platforms` flag to `bundle binstubs` to generate binstubs for all platforms (cherry picked from commit ba09c54)
Description:
What was the end-user or developer problem that led to this PR?
This closes #2120
What is your fix for the problem, implemented in this PR?
This adds
--all-platforms
option suggested by segiddinsI think the manpages also should be updated but I'm not quite sure how to go about doing that
Tasks:
I will abide by the code of conduct.