Fix error when building error message in bundler/inline
#3901
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If during a `bundler/inline` script, `Kernel.gem` is used to activate a non-available gem, `bundler` would end up using a `GemfileNotFound` error instead of a proper `LoadError`. This commit fixes the problem.
deivid-rodriguez
force-pushed
the
fix_bundler_inline_error
branch
from
fe47a22
to
b17a3d0
Compare
hsbt
approved these changes
Aug 26, 2020
|
Thanks @hsbt! |
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Fix error when building error message in `bundler/inline` (cherry picked from commit 99285a9)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Fix error when building error message in `bundler/inline` (cherry picked from commit 99285a9)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Fix error when building error message in `bundler/inline` (cherry picked from commit 99285a9)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Fix error when building error message in `bundler/inline` (cherry picked from commit 99285a9)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Fix error when building error message in `bundler/inline` (cherry picked from commit 99285a9)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Fix error when building error message in `bundler/inline` (cherry picked from commit 99285a9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
If during a
bundler/inlinescript,Kernel.gemis used to activate anon-available gem,
bundlerwould end up using aGemfileNotFounderror instead of a proper
LoadError.This commit fixes the problem.
Fixes #3726.
Tasks:
I will abide by the code of conduct.