Move shebang to the top of bin/console template

[speckins]

In an executable script, the shebang line should be the first line (the
file needs to start with the bytes 0x23 0x21). Putting a comment above
it will break the script.

[welcome]

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

[deivid-rodriguez]

Thank you, nice catch!

As illustrated by the failing specs, you need to restore the # frozen_string_literal: true line as the second line in the file.

[speckins]

I've made the requested changes.

[deivid-rodriguez]

Thanks! Just one final request, could you add a couple of lines below this code here:

rubygems/bundler/spec/commands/newgem_spec.rb

Lines 377 to 378 in 2ceb821

	expect(bundled_app("#{gem_name}/bin/setup")).to be_executable
	expect(bundled_app("#{gem_name}/bin/console")).to be_executable

to assert that the first two characters in the generated binstub are "!#"?

That way we add some test coverage for this bug fix.

[speckins]

I appended those expectations to that same test rather than creating a separate test; I hope that's okay.

[deivid-rodriguez]

Yes, it looks really good, thanks!

[hsbt]

👍