Avoid duplicated generation of APISpecification objects #3940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As far as I could see, `Gem::Resolver::APISpecification` objects are supposed to be immutable. If my guessing is correct, then we can cache and reuse its instances for performance. At least, `rake` passes on my machine. Before this change: ``` $ time ruby -I lib bin/gem install --no-doc aws-sdk Successfully installed aws-sdk-3.0.1 1 gem installed real 0m37.104s user 0m36.952s sys 0m0.333s ``` After this change: ``` $ time ruby -I lib bin/gem install --no-doc aws-sdk Successfully installed aws-sdk-3.0.1 1 gem installed real 0m23.905s user 0m23.740s sys 0m0.365s ```
|
Thanks! |
hsbt
added a commit
that referenced
this pull request
Sep 23, 2020
…specification-objects Avoid duplicated generation of APISpecification objects
eregon
reviewed
Sep 28, 2020
| ## | ||
| # We assume that all instances of this class are immutable; | ||
| # so avoid duplicated generation for performance. | ||
| @@cache = {} |
There was a problem hiding this comment.
Class variables are pretty inefficient, I think on all Ruby implementations.
Should we use a constant or @ivar on the class instead here?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
What was the end-user or developer problem that led to this PR?
gem install aws-sdkis painfully slowWhat is your fix for the problem, implemented in this PR?
As far as I could see,
Gem::Resolver::APISpecificationobjects aresupposed to be immutable. If my guessing is correct, then we can cache
and reuse its instances for performance.
At least,
rakepasses on my machine.Before this change:
After this change:
Tasks:
I will abide by the code of conduct.