Fix CI #3946
Merged
Fix CI #3946
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For better errors.
Our scripts were currently installing the exact 0.85.1 version of rubocop, but letting rubocop dependencies be resolved to the latest compatible version. Sadly, `rubocop-ast 0.4.0` was released, and started being installed here. And that broke our CI because the new version doesn't play nice with `rubocop-0.85.1`. Upgrade to the latest version, which should be compatible.
To try to prevent similar failures as the one caused by `rubocop-ast 0.4.0` in the future.
4 tasks
Closed
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 5, 2020
Fix CI (cherry picked from commit 4a33b04)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Fix CI (cherry picked from commit 4a33b04)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Fix CI (cherry picked from commit 4a33b04)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Fix CI (cherry picked from commit 4a33b04)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
What was the end-user or developer problem that led to this PR?
The release of
rubocop-ast 0.4.0broke somebundle gemtests that make surerubocopruns cleanly on a generated gem.The reason is that this new release doesn't seem compatible with the
rubocopversion we were testing against.What is your fix for the problem, implemented in this PR?
My fix is to upgrade our tests to use the latest version (which is compatible with rubocop-ast 0.4.0), and to also lock
rubocop-astto 0.4.0 to avoid similar failures in the future.Tasks:
I will abide by the code of conduct.