Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in bundle pristine warning message #3959

Merged
merged 1 commit into from
Sep 23, 2020
Merged

Fix typo in bundle pristine warning message #3959

merged 1 commit into from
Sep 23, 2020

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Sep 23, 2020

Description:

s/overriden/overridden/


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • Get code review from coworkers / friends

I will abide by the code of conduct.

s/overriden/overridden/
@simi
Copy link
Member

simi commented Sep 23, 2020

TIL [ci skip] doesn't work with GitHub Actions.

@deivid-rodriguez
Copy link
Member

deivid-rodriguez commented Sep 23, 2020

@deivid-rodriguez deivid-rodriguez changed the title Fix typos [ci skip] Fix typo in bundle pristing warning message Sep 23, 2020
@deivid-rodriguez
Copy link
Member

@hsbt I edited the title because this is the wording bundler's changelog will use, so we don't want [ci skip] in there either.

@deivid-rodriguez
Copy link
Member

deivid-rodriguez commented Sep 23, 2020

Also, isn't setting the 3.2.0 milestone a bit confusing here? Next bundler version is 2.2.0 even if we will release it in sync with rubygems 3.2.0 from this repository. I don't have a problem with it if it helps you, but I don't think there's any other bundler PR tagged with the 3.2.0 milestone.

@deivid-rodriguez deivid-rodriguez changed the title Fix typo in bundle pristing warning message Fix typo in bundle pristine warning message Sep 23, 2020
@hsbt
Copy link
Member Author

hsbt commented Sep 23, 2020

I thought that we would release bundler-2.2.0 and rubygems-3.2.0 from 3.2 branch. Because I set the 3.2.0 milestone to them. But I also okay to use bundler-2.2.0 milestone for it separated with rubygems-3.2.0 milestone.

@deivid-rodriguez What way to useful for you?

@deivid-rodriguez
Copy link
Member

I thought that we would release bundler-2.2.0 and rubygems-3.2.0 from 3.2 branch

Yes, that's the plan 👍.

Our current case is pretty unique, but normally milestones map to software versions, not to branch names, that's why when I saw the 3.2.0 milestone, I thought this PR was changing code in rubygems. So I personally find the rubygems-3.2.0 and bundler-2.2.0 convention for naming milestones more clear.

That said, you're currently the only one using milestones at the moment (I don't use them for anything), so whatever you prefer to use is fine to me.

@hsbt
Copy link
Member Author

hsbt commented Sep 23, 2020

Yes, that's the plan 👍.

👍

I renamed https://github.com/rubygems/rubygems/milestone/31 to RubyGems 3.2.0/Bundler 2.2.0 now. When we remains to confuse them, We will separate its milestone.

@hsbt hsbt merged commit d52796c into master Sep 23, 2020
@hsbt hsbt deleted the typofix branch September 23, 2020 12:45
hsbt added a commit that referenced this pull request Sep 24, 2020
Fix typo in `bundle pristine` warning message
deivid-rodriguez pushed a commit that referenced this pull request Oct 5, 2020
Fix typo in `bundle pristine` warning message

(cherry picked from commit d52796c)
deivid-rodriguez pushed a commit that referenced this pull request Oct 5, 2020
Fix typo in `bundle pristine` warning message

(cherry picked from commit d52796c)
deivid-rodriguez pushed a commit that referenced this pull request Oct 5, 2020
Fix typo in `bundle pristine` warning message

(cherry picked from commit d52796c)
deivid-rodriguez pushed a commit that referenced this pull request Oct 6, 2020
Fix typo in `bundle pristine` warning message

(cherry picked from commit d52796c)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants