Fix some warnings during bin/rake spec:deps
#3986
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If you have multiple versions of `mustache` or `rdiscount` installed on
your system and you run `bin/rake spec:deps` from the root of the
`bundler` folder, you'll get warnings like this:
```
WARN: Unresolved or ambiguous specs during Gem::Specification.reset:
rdiscount (>= 1.5.8)
Available/installed versions of this gem:
- 2.2.0.2
- 2.2.0.1
mustache (>= 0.7.0)
Available/installed versions of this gem:
- 1.1.1
- 1.0.5
- 0.99.8
WARN: Clearing out unresolved specs. Try 'gem cleanup <gem>'
Please report a bug if this causes problems.
```
The explanation is that loading the `Rakefile` requires `ronn` for
loading the man pages tasks. `rdiscount` and `mustache` are dependencies
of `ronn`, but since there are multiple versions of them on the system,
they are left unresolved until they are eventually required. However,
during `bin/rake spec:deps`, `bundler` will change the rubygems
environment to prepare for the specs and eventually calls
`Gem::Specification.reset` to apply new gem paths. Since these gems are
unresolved at that time, a warning is printed.
The solution is to lazily require ronn only when man pages tasks are
actually run.
This commit is best viewed ignoring whitespace changes.
deivid-rodriguez
force-pushed
the
fix_specification_reset_warning
branch
from
bc3b102
to
1e76992
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Fix some warnings during `bin/rake spec:deps` (cherry picked from commit 21536b3)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Fix some warnings during `bin/rake spec:deps` (cherry picked from commit 21536b3)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Fix some warnings during `bin/rake spec:deps` (cherry picked from commit 21536b3)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
Fix some warnings during `bin/rake spec:deps` (cherry picked from commit 21536b3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
If you have multiple versions of
mustacheorrdiscountinstalled on your system and you runbin/rake spec:depsfrom the root of thebundlerfolder, you'll get warnings like this:The explanation is that loading the
Rakefilerequiresronnfor loading the man pages tasks.rdiscountandmustacheare dependencies ofronn, but since there are multiple versions of them on the system, they are left unresolved until they are eventually required. However, duringbin/rake spec:deps,bundlerwill change the rubygems environment to prepare for the specs and eventually callsGem::Specification.resetto apply new gem paths. Since these gems are unresolved at that time, a warning is printed.What is your fix for the problem, implemented in this PR?
The solution is to lazily require ronn only when man pages tasks are actually run.
This commit is best viewed ignoring whitespace changes.
Tasks:
I will abide by the code of conduct.