Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct grammar in Gemfile docs #3990

Merged
merged 1 commit into from
Oct 3, 2020
Merged

Conversation

mehagar
Copy link
Contributor

@mehagar mehagar commented Oct 2, 2020

Correct grammar

Description:

What was the end-user or developer problem that led to this PR?

Noticed a grammatical error in the docs.

What is your fix for the problem, implemented in this PR?

Correct the grammar of the docs.


Tasks:

  • Describe the problem / feature
  • Write tests
  • Write code to solve the problem
  • [] Get code review from coworkers / friends

I will abide by the code of conduct.

@welcome
Copy link

welcome bot commented Oct 2, 2020

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

@deivid-rodriguez deivid-rodriguez changed the title Update gemfile.5.ronn Correct grammar in Gemfile docs Oct 3, 2020
Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this @mehagar! 💜

@deivid-rodriguez deivid-rodriguez merged commit a28724f into rubygems:master Oct 3, 2020
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Correct grammar in Gemfile docs

(cherry picked from commit a28724f)
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Correct grammar in Gemfile docs

(cherry picked from commit a28724f)
deivid-rodriguez added a commit that referenced this pull request Oct 5, 2020
Correct grammar in Gemfile docs

(cherry picked from commit a28724f)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Correct grammar in Gemfile docs

(cherry picked from commit a28724f)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Correct grammar in Gemfile docs

(cherry picked from commit a28724f)
deivid-rodriguez added a commit that referenced this pull request Oct 6, 2020
Correct grammar in Gemfile docs

(cherry picked from commit a28724f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants