Improve the independence of bundler specs from rubygems #3995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It makes the spec more independent.
All of our specs should pass against all supported versions. We should ideally backport fixes to bundler if needed and use feature detection in specs rather than filtering against specific rubygems versions, which is brittle.
deivid-rodriguez
force-pushed
the
improve_spec_independance
branch
from
c3b7693
to
3009b76
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Improve the independence of bundler specs from rubygems (cherry picked from commit d0794df)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Improve the independence of bundler specs from rubygems (cherry picked from commit d0794df)
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 6, 2020
Improve the independence of bundler specs from rubygems (cherry picked from commit d0794df)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
While creating the release PR for the next bundler version, I got a failure because I hadn't backport a rubygems PR. I shouldn't need to backport any rubygems specific PRs to get the CI green on the stable branch.
What is your fix for the problem, implemented in this PR?
I made the spec detect whether the rubygems version it's running against has the fix it needs, and skip the spec otherwise.
Also, since the :rubygems filter was unused, I removed it, since I feel it's best to always do this kind of feature detection rather than hardcoding version checks.
Make sure he following tasks are checked