Suggest alternatives in gem query deprecation
#4021
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`gem query` was deprecated in rubygems 3.2. Prior to the command being deprecated, there was an injunction to use `list` or `search`. While the `query` command is going away, the usefulness of this suggestion is still present, as pointed out in rubygems#3984.
|
Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality. We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below. If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack. For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide |
deivid-rodriguez
approved these changes
Oct 19, 2020
4 tasks
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…ves-to-deprecation-warning Suggest alternatives in `gem query` deprecation (cherry picked from commit 61447f3)
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 7, 2020
…ves-to-deprecation-warning Suggest alternatives in `gem query` deprecation (cherry picked from commit 61447f3)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
gem querywas deprecated in rubygems 3.2. Prior to the command being deprecated, there was an injunction to uselistorsearch. While thequerycommand is going away, the usefulness of this suggestion is still present, as pointed out in #3984.@deivid-rodriguez's comment on the linked issue suggested adding suggestions for the now-deprecated
querycommand, along with adding information about the deprecation to rubygems.org.Note: since the described problem requires changes in two repositories, this is the first of two pull requests to address this issue.
Make sure he following tasks are checked