Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix --platform option to gem specification being ignored #4043

Merged
merged 1 commit into from
Oct 30, 2020

Conversation

deivid-rodriguez
Copy link
Member

What was the end-user or developer problem that led to this PR?

While debugging a different issue, I wanted to know how the specification of the precompiled version of the google-protobuf gem for linux looked like.

So I was running

gem specification --remote google-protobuf --platform x86_64-linux

But I would keep getting the pure ruby version of the specification.

What is your fix for the problem, implemented in this PR?

I think, if --platform option is given, it should print only specifications for the given platform.

Make sure he following tasks are checked

I think, if `--platform` option is given, it should print only
specifications for the given platform.
Copy link
Member

@bronzdoc bronzdoc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@deivid-rodriguez deivid-rodriguez merged commit 99a9c07 into master Oct 30, 2020
@deivid-rodriguez deivid-rodriguez deleted the fix_gem_specification_platform_flag branch October 30, 2020 10:13
deivid-rodriguez added a commit that referenced this pull request Dec 7, 2020
…_flag

Fix `--platform` option to `gem specification` being ignored

(cherry picked from commit 99a9c07)
deivid-rodriguez added a commit that referenced this pull request Dec 7, 2020
…_flag

Fix `--platform` option to `gem specification` being ignored

(cherry picked from commit 99a9c07)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants