-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use better owner & group for files in rubygems package #4065
Conversation
This is consistent with the official ruby package and makes it possible to unpack the rubygems package inside a rootless docker container.
Thanks @bronzdoc! |
@hsbt Since you're the one generating this package normally, I should've probably asked you to try this out before merging, my bad. Can you try it and verify that there are no issues and that the files doesn't have weird UID and GID inside the package? |
I tested it with
2033490572 is my company ActiveDirectory GID. It doesn't seem the expected behavior. What's wrong? |
Interesting. Did you have a previous rubygems-3.2.0.rc.2.tar file? Maybe you need to delete that so that it's regenerated with the proper permissions? 🤔 |
Not very optimistic that's the cause though. Can you also verify that |
Ah, It seems fine.
I did confirm the ownership with extracted files. |
Cool! |
Use better owner & group for files in rubygems package (cherry picked from commit 70d836d)
Use better owner & group for files in rubygems package (cherry picked from commit 70d836d)
Use better owner & group for files in rubygems package
Use better owner & group for files in rubygems package
@deivid-rodriguez thank you for driving this. My understanding is that this fix isn't included yet in any release. When do you expect to have it released? |
It should be released since 3.2.0 I believe? Did you see this weirdness on a recent version? |
Sorry, I thought that it is not yet released because the commit of this pr is available on on master. We will check and provide feedback. Thanks! |
What was the end-user or developer problem that led to this PR?
The rubygems package we're currently shipping can't be extracted inside a docker container.
The problem is detailed at #3977 (comment).
The TL;DR is that depending on which system is used to create the package, the packaged files can have very high UID and GUID, and inside a rootless docker container,
tar
can't handle those.What is your fix for the problem, implemented in this PR?
My fix is to pass explicit group and owner to the
tar
command that creates the package, so thattar
can handle it.The values are consistent with what's included in the official ruby package, so I believe they should work fine.
Fixes #3977.
Make sure he following tasks are checked