Fix Resolver::APISet to always include prereleases when necessary #4113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 9, 2020
Previous versions of molinillo, specifically before CocoaPods/Molinillo@d29a053, would include special logic for dealing with prereleases. Now this logic needs to be implemented by the specification provider, in this case, rubygems. That change in molinillo made an issue in our `Resolver::APISet` implementation manifest, where even if the set has been created with the `prerelease` flag, it would fail to return prereleases unless the dependency explicitly allowed them. For example, it would return prereleases given the dependency "activesupport, = 6.1.rc2", but it will fail to return prereleases given the dependency "activesupport, >= 4.2.0". In the latter case, we also want prereleases returned when the `--pre` flag has been passed to `gem install`, i.e., when the API set has been created with the prerelease flag.
deivid-rodriguez
force-pushed
the
fix_gem_install_pre
branch
from
c5d8d3c
to
9d852e2
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 14, 2020
Fix Resolver::APISet to always include prereleases when necessary (cherry picked from commit b70b07b)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
fails to install the latest rails prerelease.
What is your fix for the problem, implemented in this PR?
Previous versions of molinillo, specifically before CocoaPods/Molinillo@d29a053, would include special logic for dealing with prereleases. Now this logic needs to be implemented by the specification provider, in this case, rubygems.
That change in molinillo made an issue in our
Resolver::APISetimplementation manifest, where even if the set has been created with theprereleaseflag, it would fail to return prereleases unless the dependency explicitly allowed them. For example, it would return prereleases given the dependency "activesupport, = 6.1.rc2", but it will fail to return prereleases given the dependency "activesupport, >= 4.2.0". In the latter case, we also want prereleases returned when the--preflag has been passed togem install, i.e., when the API set has been created with the prerelease flag.Fixes #4112.
Make sure the following tasks are checked