Workaround JRuby + Windows issue with net-http-persistent vendored code

[slonopotamus]

Closes #4129.

[welcome]

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

[deivid-rodriguez]

The whole test suite is suuuupuuuuuuuer slow on jruby, not really acceptable for running on every PR, and also it doesn't fully pass. If you can take care of skipping everything that currently fails on jruby, and move it to a daily job, I think it could be acceptable. Alternatively I would write a single test that catches the issue we're facing now and run just that.

[deivid-rodriguez]

Actually it seems that merely installing dependencies fails due to this issue? In that case, I think we can just test that :)

[slonopotamus]

I actually was not sure where to add JRuby+Windows combo. You have .github/workflows/jruby-bundler.yml that tests JRuby only on Linux but also have .github/workflows/windows-bundler.yml that tests multiple Rubies on Windows.

[slonopotamus]

Okay, at least it actually reproduces exact issue that happened in #4129: https://github.com/rubygems/rubygems/runs/1545806033?check_suite_focus=true#step:4:12

[deivid-rodriguez]

Yep, that's what I was saying. Where you added jruby is the right place. What I'd do for now is to limit the jruby job to just run the bin/rake spec:parallel_deps task, since that itself reproduces the issue, and running the full test suite is not going to work. I'd add a if: "!startsWith(matrix.ruby, 'jruby')" to all steps except for the one installing dependencies and before.

[headius]

The fix as written is simple and will cover all known breaking cases.

I think we should also try to get this into net-http-persistent since that library is now also broken for JRuby 9.2.14.0 and earlier on Windows.

[deivid-rodriguez]

Yes, I'm planning to forward port the fix to net-http-persistent too 👍.