Fix building rake extensions that require openssl #4165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We were passing an incorrect folder, and one which has a `openssl.rb` file inside. So this file was shadowing the require of the "real openssl". This `-I` parameter is not really needed in real life I believe, since there can be at most one rubygems installation at a given ruby installation. I think the idea of this parameter is that our tests never leak to the "system rubygems", because when testing there are two copies of rubygems involved (the one being tested, and the one from the ruby we're running). I'm not sure using this `-I` parameter here is a good idea, so since I'm not sure I'm just keeping things as they are for now and fixing the bug.
Closed
5 tasks
deivid-rodriguez
changed the title
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 17, 2020
Fix building rake extensions that require openssl (cherry picked from commit bee7cc7)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Building a rake extension that requires openssl fails.
What is your fix for the problem, implemented in this PR?
We were passing an incorrect folder, and one which has a
openssl.rbfile inside. So this file was shadowing the require of the "real openssl".
This
-Iparameter is not really needed in real life I believe, since there canbe at most one rubygems installation at a given ruby installation. I think the
idea of this parameter is that our tests never leak to the "system rubygems",
because when testing there are two copies of rubygems involved (the one being
tested, and the one from the ruby we're running).
I'm not sure using this
-Iparameter here is a good idea, so since I'm notsure I'm just keeping things as they are for now and fixing the bug.
Fixes #4161.
Make sure the following tasks are checked