Never spawn subshells when building extensions #4190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
never_spawn_new_shells_when_building_extensions
branch
2 times, most recently
from
6cb369c
to
7778758
Compare
4 tasks
deivid-rodriguez
force-pushed
the
never_spawn_new_shells_when_building_extensions
branch
from
7778758
to
d183030
Compare
simi
reviewed
Dec 23, 2020
deivid-rodriguez
force-pushed
the
never_spawn_new_shells_when_building_extensions
branch
from
d183030
to
a5b5371
Compare
4 tasks
These commands are already escaped. Calling `inspect` here adds a second level of escaping, making the errors super confusing. Also, when dealing with multiline output, I find it nice to add some clear delimiters of where the output begins and ends.
As a result, we no longer need to manually quote `DESTDIR`, and all commands printed as part of error messages are now properly escaped so they can be copy-pasted directly into the shell. Co-authored-by: Nobuyoshi Nakada <nobu@ruby-lang.org>
deivid-rodriguez
force-pushed
the
never_spawn_new_shells_when_building_extensions
branch
from
a5b5371
to
ad632bb
Compare
4 tasks
deivid-rodriguez
deleted the
never_spawn_new_shells_when_building_extensions
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Dec 29, 2020
…ilding_extensions Never spawn subshells when building extensions (cherry picked from commit 57fb2d1)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
In #4189 I was expecting CI to pass, however it failed because apparently on Windows,
Open3.capture2edoes not seem to start a new shell even when given a string argument, and that made my changes break some tests.I think not spawning a new shell should be our default behaviour.
What is your fix for the problem, implemented in this PR?
My fix is to change our
Open3.capture2ecalls to always receive an array, so that it always try to run the command directly instead of starting a new shell.Make sure the following tasks are checked