Fix another performance regression in the resolver #4243
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only add a fallback ruby specific group if the dependencies for the platform specific spec group different from the ones for the ruby group.
deivid-rodriguez
force-pushed
the
fix_resolver_slowdown
branch
from
2ca9edb
to
844508c
Compare
|
fix_resolver_slowdown |
|
Wtf I didn't know I'm sorry. I'll leave your GitHub alone
…On Thu, Jan 7, 2021, 4:52 AM David Rodríguez ***@***.***> wrote:
Merged #4243 <#4243> into master.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#4243 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ASMDBIJMAQ73QDZCY3NL3Y3SYWOA5ANCNFSM4VXQHTZA>
.
|
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 11, 2021
Fix another performance regression in the resolver (cherry picked from commit bb292e0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Resolver performance has degraded so much after adding our multiplatform fixes that in some cases that resolving can no longer finish on a reasonable time.
What is your fix for the problem, implemented in this PR?
My fix is to make sure we only add a "ruby fallback" spec group when necessary, namely, when the dependencies of the platform specific version of a spec group are different from the dependencies of the RUBY version of it.
I tested locally and it seems to work fine, but still needs to go through the full CI check.
Fixes #4240.
Make sure the following tasks are checked