Don't load more specs after the whole set of specs has been setup #4262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix_stub_over_loading
branch
from
15ddde4
to
5225527
Compare
deivid-rodriguez
changed the title
@@stubs have been set
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 11, 2021
Don't load more specs after the whole set of specs has been setup (cherry picked from commit 7809f5e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
If bundler is being used, and spec is not included in the bundle,
Gem::Specification.find_by_namewill still leak outside of the bundle and find globally installed specs.What is your fix for the problem, implemented in this PR?
This is a regression of #2711.
The lazy loading provided by that PR when the whole set of
@@stubsis not yet set is still interesting, so I kept that but restored the old behaviour of not trying to load anything else once@@stubshave been set.Fixes #4253.
Make sure the following tasks are checked