Restore accepting custom make command with extra options as the make env variable
#4271
Conversation
Debian's gem2deb passes a set of build variables to Rubygems extension builders using ENV['make']. These options are used to produce hardened binaries, as well as to help with reproducible builds. This fixes a regression introduced by ad632bb.
terceiro
changed the title
deivid-rodriguez
changed the title
make env variable
|
@terceiro I'm planning to get this fix out in about a week. |
|
@terceiro I was thinking about this, and while I'm happy to fix this regression and get you back on track,I wonder if this is the right thing to do. I would've never expected people to pass command line flags as part of Is this something you do often, and that other libraries usually support? Would it be better that we respected a separate environment variable for this, such as, |
|
@deivid-rodriguez in my experience most projects that support overriding commands with environment variables like this will usually handle a command with extra arguments, but I don't really have data to prove it. Maybe we could use MAKEFLAGS as well, in this case I think rubygems would not need to do anything. |
|
Yeah, I think you're right. I just remembered how Thanks for the feedback, your fix is good 👍. |
Restore accepting custom make command with extra options as the `make` env variable (cherry picked from commit fdc5cfa)
What was the end-user or developer problem that led to this PR?
Debian's gem2deb passes a set of build variables to Rubygems extension builders using ENV['make']. These options are used to produce hardened binaries, as well as to help with reproducible builds.
After ad632bb, it no longer works.
What is your fix for the problem, implemented in this PR?
Consider this case and shellsplit it before passing it to process spawning helpers.
Make sure the following tasks are checked