Fix force_ruby_platform no longer being respected
#4302
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
deleted the
fix_force_ruby_platform_no_longer_respected
branch
|
@deivid-rodriguez thank you very much for fixing this! Any idea when we can expect the fix to be released? |
|
I'll try to get it released today or tomorrow. |
|
Thanks! Much appreciated! |
deivid-rodriguez
added a commit
that referenced
this pull request
Jan 26, 2021
…ger_respected Fix `force_ruby_platform` no longer being respected (cherry picked from commit 9f06f51)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Since 2.2.3,
force_ruby_platformis no longer being respected.What is your fix for the problem, implemented in this PR?
In 2.2.3, I added some backwards compatibility code to restore pre bundler 2.2.0 behaviour of choosing the best matching platform at installation time rather than at resolution time like it's done now.
However, I missed to exclude
force_ruby_platformfrom that since in this case we never what to select any platform specific gems at all.Fixes #4296.
Make sure the following tasks are checked