Don't install platform specific gems on truffleruby #4333
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
truffleruby_platform_specific_deps
branch
2 times, most recently
from
8d8290f
to
f49fca1
Compare
It's more straightforward.
Truffleruby lazily loads rubygems. Avoid that so that our reexec logic works there too.
deivid-rodriguez
force-pushed
the
truffleruby_platform_specific_deps
branch
from
f49fca1
to
acd7e4e
Compare
deivid-rodriguez
force-pushed
the
truffleruby_platform_specific_deps
branch
from
04f5352
to
acd7e4e
Compare
|
It should be ready now! I added a bare truffleruby bundler CI to make sure the issue is caught: https://github.com/rubygems/rubygems/pull/4333/checks?check_run_id=1822918747. |
eregon
approved these changes
Feb 3, 2021
|
It'd be great to merge this and have a release, we're seeing more reports of this issue (e.g., oracle/truffleruby#2246) |
|
I'll release this at the beginning of next week. |
deivid-rodriguez
pushed a commit
that referenced
this pull request
Feb 8, 2021
…deps Don't install platform specific gems on truffleruby (cherry picked from commit d7941db)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Sometimes platform specific specs are installed on truffleruby.
What is your fix for the problem, implemented in this PR?
Handle the case where an implementation registers itself as a "pure ruby platform" by setting
Gem.platforms == [Gem::Platform::RUBY].Fixes #4330.