Fix adding platforms to lockfile sometimes conflicting on ruby requirements #4371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
metadata_dependencies_resolver_regression
branch
from
e82df32
to
85d3042
Compare
Our previous logic for selecting platform specific dependencies was applying to metadata dependencies, which is unexpected.
deivid-rodriguez
force-pushed
the
metadata_dependencies_resolver_regression
branch
from
85d3042
to
11afb35
Compare
deivid-rodriguez
deleted the
metadata_dependencies_resolver_regression
branch
deivid-rodriguez
added a commit
that referenced
this pull request
Feb 15, 2021
…_regression Fix adding platforms to lockfile sometimes conflicting on ruby requirements (cherry picked from commit 1c70599)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Since 1f7797a, adding platforms to lockfiles sometimes conflicts on ruby version requirements.
What is your fix for the problem, implemented in this PR?
Our previous logic for selecting platform specific dependencies was applying to metadata dependencies, which is unexpected. So consider metadata dependencies as generic, so that their spec groups never get platforms activated/deactivated dinamically.
Fixes #4366.
Make sure the following tasks are checked