Warn lockfiles with incorrect resolutions #4459
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fail_lockfiles_with_incorrect_resolutions
branch
2 times, most recently
from
f53831e
to
48c6a89
Compare
deivid-rodriguez
force-pushed
the
fail_lockfiles_with_incorrect_resolutions
branch
from
48c6a89
to
f7a25dc
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Mar 18, 2021
…resolutions Warn lockfiles with incorrect resolutions (cherry picked from commit 1140686)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
I was going to investigate #4319, and I noticed that the OP shared a lockfile that includes an invalid resolution 😨.
My guess (and hope) is that the OP edited the lockfile directly in an incorrect way. The other possibility (which I hope it's not the case), is that bundler is generating these incorrect lockfiles.
In any case, I think it doesn't hurt to print a warning about the situation, because right now this results in bundler seamlessly installing gems that are incompatible with each other.
What is your fix for the problem, implemented in this PR?
My fix is to check whether specs in the lockfile are compatible with all dependencies in there, and print a warning otherwise.
Make sure the following tasks are checked