Prefer File.open instead of Kernel#open #4529
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... because Kernel#open may allow unintentional command injection. At present, I don't know how to exploit these usages of Kernel#open, but I'm afraid if they may be used with untrusted user input accidentally in future. As far as I see, there is no reason to use Kernel#open.
|
👍 |
mame
added a commit
to mame/rubygems
that referenced
this pull request
Apr 13, 2021
Ditto to IO.readlines. IO.read and IO.readlines may run a command. Related: rubygems#4529
4 tasks
|
@hsbt I don't think this is a security fix, since I don't think it can really be exploited at the moment. I think it's better to tag it as |
|
I have no strong opinion to remain that. I replaced your suggestion. |
|
Alright @hsbt! It just felt to me that tagging this as a security fix would essentially imply that everyone using |
deivid-rodriguez
pushed a commit
that referenced
this pull request
May 3, 2021
…-open Prefer File.open instead of Kernel#open (cherry picked from commit 4795180)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... because Kernel#open may allow unintentional command injection.
At present, I don't know how to exploit these usages of Kernel#open, but
I'm afraid if they may be used with untrusted user input accidentally in
future. As far as I see, there is no reason to use Kernel#open.