Simplify setup.rb code to allow installing rubygems from source on truffleruby 21.0 and 21.1 #4624
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous way was hitting a bug in truffleruby, make `ruby setup.rb` crash under than implementation.
simi
reviewed
May 26, 2021
simi
approved these changes
May 26, 2021
deivid-rodriguez
changed the title
setup.rb codesetup.rb code to allow installing rubygems from source on truffleruby 21.0 and 21.1
deivid-rodriguez
changed the title
setup.rb code to allow installing rubygems from source on truffleruby 21.0 and 21.1setup.rb code
deivid-rodriguez
changed the title
setup.rb code
deivid-rodriguez
added
rubygems: enhancement
and removed
rubygems: skip changelog
labels
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 23, 2021
Simplify `setup.rb` code (cherry picked from commit 9e2c1ea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The previous way was hitting a bug in truffleruby, making
ruby setup.rbcrash under than implementation.What is your fix for the problem, implemented in this PR?
Do things in a simpler way.
Make sure the following tasks are checked