Allow setting --otp via GEM_HOST_OTP_CODE

[CGA1123]

What was the end-user or developer problem that led to this PR?

For release automation it can be nice to want to pass in the OTP via
some UI (e.g. a workflow_dispatch input on GitHub Actions) and then just
be able to run rake release to publish to rubygems.

What is your fix for the problem, implemented in this PR?

This introduces a new environment variable GEM_HOST_OTP_CODE which
will take precendence over --otp command line options, allowing for
automated releases with OTP.

Make sure the following tasks are checked

• Describe the problem / feature
• Write tests for features and bug fixes
• Write code to solve the problem
• Make sure you follow the current code style and write meaningful commit messages without tags

[welcome]

Thanks for opening a pull request and helping make RubyGems and Bundler better! Someone from the RubyGems team will take a look at your pull request shortly and leave any feedback. Please make sure that your pull request has tests for any changes or added functionality.

We use GitHub Actions to test and make sure your change works functionally and uses acceptable conventions, you can review the current progress of GitHub Actions in the PR status window below.

If you have any questions or concerns that you wish to ask, feel free to leave a comment in this PR or join our #rubygems or #bundler channel on Slack.

For more information about contributing to the RubyGems project feel free to review our CONTRIBUTING guide

[deivid-rodriguez]

I think this can be useful, yeah! But shouldn't the CLI flag still take precedence over the environment variable?

@sonalkr132 What do you think about this?

[CGA1123]

@deivid-rodriguez I think that is also reasonable. I went with ENV first as that matches the behaviour of api_key!

[deivid-rodriguez]

Oh, I see! In my opinion that's a bug in api_key priority, so I'd rather make it right for otp this time and open a ticket about the api_key issue.

[CGA1123]

That makes sense, explicit cli options should take precedence over environment variables 👍🏼

I'll fix the precedence here and I can also likely get a PR to fix for api_key up as well!

[deivid-rodriguez]

👍

[sonalkr132]

LGTM. Thanks you @CGA1123

[deivid-rodriguez]

Thanks! ❤️

[ybiquitous]

Hi there, thank you so much for shipping this feature! I have really wanted it. 🥰

BTW, I cannot find a description about GEM_HOST_OTP_CODE in gem push —help. 🤔
Are you going to add it to the help?

[deivid-rodriguez]

PR welcome!

[ybiquitous]

@deivid-rodriguez Thanks. I've created PR #4742.