Show original error and backtrace directly on bundle install errors instead of a more brittle gem install hint
#4778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For example, due to extension compilation issues.
A fresh `gem install` might not reproduce the exact `bundle install` environment that originally caused the error. It also makes it harder for the user to troubleshoot the error since she needs to run a separate command. Instead, show the original error and backtrace directly.
deivid-rodriguez
added a commit
that referenced
this pull request
Jul 30, 2021
Show original error and backtrace directly on `bundle install` errors instead of a more brittle `gem install` hint (cherry picked from commit 1462d5c)
deivid-rodriguez
added a commit
that referenced
this pull request
Jul 30, 2021
Show original error and backtrace directly on `bundle install` errors instead of a more brittle `gem install` hint (cherry picked from commit 1462d5c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When
bundle installfails to install a specific gem (most common case, extension compilation fails), it will suggest and alternativegem installcommand that might make it easier to figure out the culprit. However, it's hard to reproduce the exact environment where the installation failed as a fresh pristine command, and sometimes the suggestedgem installcommand will succeed whilebundle installwill keep failing.What is your fix for the problem, implemented in this PR?
My fix is to completely remove the
gem installsuggestion and show the original error with a backtrace instead.Fixes #3321.
Make sure the following tasks are checked