Fix bundle gem on path with spaces
#4816
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix_bundle_gem_on_path_with_spaces
branch
from
971bac5
to
c31b8cd
Compare
olleolleolle
reviewed
Aug 4, 2021
olleolleolle
approved these changes
Aug 4, 2021
|
Thanks for your review @olleolleolle! |
deivid-rodriguez
added a commit
that referenced
this pull request
Aug 17, 2021
…aces Fix `bundle gem` on path with spaces (cherry picked from commit e56c785)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
bundlerwould fail to initialize the fresh git repository of new gems whenbundle gemis run inside a path with spaces.What is your fix for the problem, implemented in this PR?
Properly shellescape target folder.
Closes #4622.
Make sure the following tasks are checked