Only check if descriptions *start with* FIXME/TODO #4841
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
bronzdoc
reviewed
Aug 13, 2021
It doesn't make much sense to just forbid certain words in descriptions.
duckinator
force-pushed
the
issue-4808
branch
from
0c50fd5
to
7890c98
Compare
|
@bronzdoc @deivid-rodriguez I think this should be good to go now. |
5 tasks
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 22, 2021
Only check if descriptions *start with* FIXME/TODO (cherry picked from commit 8721fe2)
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4808.
What was the end-user or developer problem that led to this PR?
RubyGems outright forbids the words "FIXME" or "TODO" in a gem description.
What is your fix for the problem, implemented in this PR?
I made RubyGems only check if the gem description starts with "FIXME" or "TODO".
Make sure the following tasks are checked