Prioritise gems with higher version for fetching metadata, and stop fetching once we find a valid candidate #4843
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
intuxicated
force-pushed
the
dan/fix-issue-4585
branch
3 times, most recently
from
3df0884
to
e879849
Compare
intuxicated
changed the title
intuxicated
force-pushed
the
dan/fix-issue-4585
branch
3 times, most recently
from
3561e3c
to
06f018d
Compare
intuxicated
commented
Aug 15, 2021
intuxicated
force-pushed
the
dan/fix-issue-4585
branch
from
06f018d
to
8e2c79a
Compare
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
intuxicated
force-pushed
the
dan/fix-issue-4585
branch
from
4e6b5dd
to
e3d150d
Compare
deivid-rodriguez
changed the title
gem install when index includes gems that don't exist but that don't affect resolution because there are other existing gems with more priority
deivid-rodriguez
approved these changes
Aug 19, 2021
4 tasks
deivid-rodriguez
changed the title
gem install when index includes gems that don't exist but that don't affect resolution because there are other existing gems with more priority
|
|
deivid-rodriguez
added a commit
that referenced
this pull request
Sep 2, 2021
Prioritise gems with higher version for fetching metadata, and stop fetching once we find a valid candidate (cherry picked from commit 2063a3e)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Github has an issue in which it will generate a misleading prerelease output in its RubyGems server API and returns a 0 version for the gem while it doesn't exist.
What is your fix for the problem, implemented in this PR?
Verifying metadata (which needs a network request to fetch the full gemspec) in order of priority until a valid gem is found, instead of fetching all gemspec candidates unconditionally, avoids the issue.
Fixes #4603.
Make sure the following tasks are checked