Fix install crash when lockfile has missing dependencies for the current platform #4941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
fix_install_crash
branch
3 times, most recently
from
07ca584
to
98bf184
Compare
It doesn't really need converged specs, since it's only about the lockfile.
This is exclusively about the lockfile.
In case we have a corrupted lockfile that claims to support a platform, but it's missing platform specific gems for it, bundler has a check that detects the situation and forces a re-resolve. The result of this check is kept under the `@locked_specs_incomplete_for_platformn` instance variable in `Definition`. The installer, however, calls `Definition#nothing_changed?` before this instance variable has been filled, so the result of it is actually incorrect here since it will claim that nothing has changed, but something has changed (locked specs are incomplete for the current platform). The consequence of this incorrect result is that the installer thinks it can go on without re-resolving, resulting in the incomplete resolution from the lockfile being used, and in a crash being triggered due to that. The solution is to make sure the `@locked_specs_incomplete_for_platform` instance variable is filled before `nothing_changed?` gets called. Moving it to `initialize` makes the most sense, not because it's the best place for it (we can refactor this later), but because all of the other "outdated definition" checks are already set there.
deivid-rodriguez
force-pushed
the
fix_install_crash
branch
from
98bf184
to
708afdd
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Oct 25, 2021
Fix install crash when lockfile has missing dependencies for the current platform (cherry picked from commit fb12b85)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Running
bundle installon a lockfile apparently generated with new rails applications causes bundler to crash.What is your fix for the problem, implemented in this PR?
My fix is to refactor
Definitionto make sure that the case of missing gems in the lockfile for the current platform is properly detected and a re-resolve is triggered to fix the situation.Fixes #4922.
Make sure the following tasks are checked