Fix gem installation failing in Solaris due to bad IO#flock usage
#5216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`io.flock(File::LOCK_EX)` fails on Solaris when the io is opened as read-only. Due to this issue, `make install` of the ruby package failed on Solaris.
deivid-rodriguez
approved these changes
Dec 24, 2021
deivid-rodriguez
changed the title
IO#flock usage
deivid-rodriguez
pushed a commit
that referenced
this pull request
Dec 24, 2021
Do not use IO#flock on Solaris (cherry picked from commit edbf790)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
make installof the ruby package fails on Solaris.What is your fix for the problem, implemented in this PR?
io.flock(File::LOCK_EX)fails on Solaris when the io is opened asread-only. This change avoids the lock mechanism on Solaris.
See also my comments #5208 (comment)
Make sure the following tasks are checked