Show better error when previous installation fails to be removed #5564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
better-rm-rf-error
branch
2 times, most recently
from
e37857d
to
f161f1a
Compare
Instead of guessing on the culprit. We actually have a helper, `Bundler.rm_rf`, with exactly the behavior that we want: * Allow the passed folder to not exist. * No exception swallowing other than that.
deivid-rodriguez
force-pushed
the
better-rm-rf-error
branch
from
f161f1a
to
5fa3e6f
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 1, 2022
Show better error when previous installation fails to be removed (cherry picked from commit 79f72c9)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
A while ago we improved our handling of permission issues, but detecting when a preexisting installation of a gem fails to be removed, and raise an error, instead of silently ignoring the issue and crash with a more confusing error somewhere else.
I've seen the new error in the wild, and although better, it doesn't make it clear what the original error was that prevented Bundler from being able to delete the folder.
What is your fix for the problem, implemented in this PR?
My fix is to use a better helper for deleting folder, that does not swallow any errors, and properly report the underlying issue when errors happen.
Make sure the following tasks are checked