Stop using /dev/null
for silent ui for WASI platform
#5703
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
WASI doesn't guarantee that
/dev/null
is present.So before this patch, we needed to mount host's
/dev
directory to WASI guest process to avoidENOTCAPABLE
error whilerequire "bundler/setup"
Here is how to reproduce the problem.
If you add
--mapdir /dev::/dev
option to wasmtime command as a workaround, it runs expectedly.What is your fix for the problem, implemented in this PR?
This patch removes the use of
/dev/null
inGem::SilentUI
to avoid the workaround.Make sure the following tasks are checked