Added multiple argument handling to gem list #604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @cmd.execute | ||
| end | ||
|
|
||
| assert_equal '', @ui.error |
There was a problem hiding this comment.
you should also assert that both a and b appear in the output, perhaps assert_match %r%^a %, @ui.output and the same for b
There was a problem hiding this comment.
@drbrain will do however the assert_match statement is not clear to me...%r%^a %?
There was a problem hiding this comment.
you get warnings with /.../ regexps without using (). %r%…% is an alternate way of writing the regexp and avoids the warning.
There was a problem hiding this comment.
@drbrain got it. good to know.
|
This looks great! My only remaining issue is that "name" should be "names" in the top block of QueryCommand#execute because it is an Array of potentially multiple items. I will merge this after RubyGems 2.1 is released. |
drbrain
added a commit
that referenced
this pull request
Sep 16, 2013
gem list now lists results for multiple arguments
drbrain
added a commit
that referenced
this pull request
Sep 16, 2013
drbrain
added a commit
that referenced
this pull request
Sep 16, 2013
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@drbrain hopefully this is it! No failing tests and operates as expected!