Fix host on gem push, when not passing a --host #622
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After d3f91a0 we start accepting the option --host on the push command However when the --host is not provided, it is set as nil, and this was causing the following output Enter your credentials. Dont have an account yet? Create one at https:///sign_up
|
👍 |
|
ping for review and merge. |
|
I don't know how this escaped me, sorry! I'll check it for 2.1 tomorrow. |
drbrain
added a commit
that referenced
this pull request
Sep 6, 2013
Allow rubygems.org credential creation without --host Fixes #622
drbrain
added a commit
that referenced
this pull request
Sep 6, 2013
drbrain
added a commit
that referenced
this pull request
Sep 9, 2013
Parentheses were missing the test added in #622
drbrain
added a commit
that referenced
this pull request
Sep 24, 2013
drbrain
added a commit
that referenced
this pull request
Sep 24, 2013
Parentheses were missing the test added in #622
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After d3f91a0 we start accepting the option --host on the push command.
However when the --host is not provided, it is set as nil, and this was causing the following output:
With the patch, on
sign_in, we get the host even if a nil one is provided.