-
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ruby 3.2 and 3.3 platforms to Gemfile DSL #6346
Conversation
Seeing #5469 (comment), I played around with a test to catch this earlier in the future, and ended up with something like this: it "allows platforms matching the running Ruby version" do
platform = "ruby_#{RbConfig::CONFIG["MAJOR"]}#{RbConfig::CONFIG["MINOR"]}"
subject.gem("foo", :platform => platform)
end Do you think that is worth adding? Or is there a better way of getting at that? |
349ee02
to
e81afca
Compare
Nice, I like it! It should make our daily CI against ruby-head fail, and then fixed after adding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving the current changeset since it seems good to introduce right away, but feel free to also add the extra spec on this PR if you prefer!
e81afca
to
1333350
Compare
Confirmed the test fails on 3.3: https://github.com/rubygems/rubygems/actions/runs/4106956899/jobs/7085847793
|
1333350
to
8f6c01d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a bunch!
https://github.com/rubygems/rubygems/actions/runs/4107455290/jobs/7086969404 looks like it succeeded, but is stuck 😕 |
Indeed, it seems like an actions glitch? |
8f6c01d
to
87f2209
Compare
Along the same lines as rubygems#5469, this adds support for Ruby 3.2 and 3.3 platforms: `:ruby_32`, `mri_32`, etc. It also includes a spec that should help catch this earlier in the future, failing if we don't support platforms for the version of Ruby that is running the tests.
Head branch was pushed to by a user without write access
87f2209
to
7cd19d8
Compare
This time https://github.com/rubygems/rubygems/actions/runs/4112632902/jobs/7097788892 got cancelled for some reason 😢 I'll rebase to trigger this one more time 🤞🏻 |
Oh boy, sorry about that. Our CI has become a little bit unstable since adding Ruby 3.2 :( |
Finally 🟢 💪. |
Add Ruby 3.2 and 3.3 platforms to Gemfile DSL (cherry picked from commit c31c575)
What was the end-user or developer problem that led to this PR?
Ruby 3.2 platforms are not yet supported in the Gemfile DSL:
What is your fix for the problem, implemented in this PR?
Along the same lines as #5469, this adds support for Ruby 3.2 platforms.
Make sure the following tasks are checked