Make frozen setting take precedence over deployment setting
#6685
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
frozen-vs-deployment
branch
from
1d99b66
to
42b4280
Compare
deivid-rodriguez
force-pushed
the
frozen-vs-deployment
branch
from
42b4280
to
5e25f8b
Compare
The behavior is not actually changing.
The `deployment` setting means `frozen` + `path=vendor/bundler`. The path can be already overridden with an explicit `path` setting, but that was not the case for `frozen`. Make this consistent and allow properly overriding `frozen` too when `deployment` is set.
Now that frozen can be overridden when deployment is set, we can always suggest setting that.
deivid-rodriguez
force-pushed
the
frozen-vs-deployment
branch
from
5e25f8b
to
c6c0463
Compare
deivid-rodriguez
changed the title
frozen setting take precedence over deployment setting
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 8, 2023
Make `frozen` setting take precedence over `deployment` setting (cherry picked from commit 21c80fc)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Relationship between
frozenanddeploymentsetting is unclear.What is your fix for the problem, implemented in this PR?
Deployment behaves like
frozen+path=vendor/bundle. Settingpathexplicitly can override this, however, settingfrozenexplicitly would not override frozenness.This PR makes
frozenconsistent in that regard.With this change, I no longer see the need of deprecating
deployment, so this PR closes #4534.Make sure the following tasks are checked