Fix deployment vs path precedence
#6703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They are already tested above.
These should all be passing on Bundler 3.
The `deployment` setting sets `path` to `vendor/bundle` implicitly, but that should only apply if `path` is not set explicitly, at any level.
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 8, 2023
Fix `deployment` vs `path` precedence (cherry picked from commit 2365016)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
The
deploymentsetting setspathtovendor/bundleimplicitly. However, whenBUNDLE_PATHis also set, whatever set there should take precedence. That was not happening.What is your fix for the problem, implemented in this PR?
Implement correct precedence logic.
Fixes #6669.
Make sure the following tasks are checked