gem sources --list doesn't print anything to the terminal #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When "--list" or "-l" is passed to "gem sources", the command is currently ignoring it.
drbrain
added a commit
that referenced
this pull request
Oct 9, 2013
gem sources --list doesn't print anything to the terminal
drbrain
added a commit
that referenced
this pull request
Oct 9, 2013
Pull request #672 fixes `gem sources --list`, but does not include a test to verify. This test will verify the pull request.
drbrain
added a commit
that referenced
this pull request
Oct 9, 2013
Pull request #672 fixes `gem sources --list`, but does not include a test to verify. This test will verify the pull request.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit d58c5b2 introduces a bug in the "gem sources" command.
When "--list" or "-l" is passed to "gem sources", the command is currently ignoring it (nothing is printed to terminal).
Currently, when options[:list] is set (by passing -l or --list), the list() method is never reached.