Avoid infinite loops when hitting resolution bugs #6722
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hsbt
approved these changes
Jun 5, 2023
deivid-rodriguez
changed the title
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 8, 2023
Bump pub grub to latest (cherry picked from commit 7988659)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
In some edge cases, the new resolver may end up looping infinitely, for example #6686 or #6601.
What is your fix for the problem, implemented in this PR?
This does not fix the root cause, but changes the infinite loop with a resolution error. I think that's better than hanging forever.
Make sure the following tasks are checked