Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop publishing Gemfile in default gem template #6723

Merged
merged 1 commit into from
Jun 8, 2023
Merged

Stop publishing Gemfile in default gem template #6723

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion bundler/lib/bundler/templates/newgem/newgem.gemspec.tt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ Gem::Specification.new do |spec|
# The `git ls-files -z` loads the files in the RubyGem that have been added into git.
spec.files = Dir.chdir(__dir__) do
`git ls-files -z`.split("\x0").reject do |f|
(File.expand_path(f) == __FILE__) || f.start_with?(*%w[bin/ test/ spec/ features/ .git .circleci appveyor])
(File.expand_path(f) == __FILE__) ||
f.start_with?(*%w[bin/ test/ spec/ features/ .git .circleci appveyor Gemfile])
end
end
spec.bindir = "exe"
Expand Down
8 changes: 8 additions & 0 deletions bundler/spec/commands/newgem_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -638,6 +638,14 @@ def create_temporary_dir(dir)
expect(bundler_gemspec.files).not_to include("#{gem_name}.gemspec")
end

it "does not include the Gemfile file in files" do
bundle "gem #{gem_name}"

bundler_gemspec = Bundler::GemHelper.new(bundled_app(gem_name), gem_name).gemspec

expect(bundler_gemspec.files).not_to include("Gemfile")
end

it "runs rake without problems" do
bundle "gem #{gem_name}"

Expand Down