Improve edge case error message #6733
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deivid-rodriguez
force-pushed
the
improve-error-message-in-frozen-mode
branch
from
c15facb
to
b7d535b
Compare
For conciseness and consistency with printing the relative path to the lockfile just before.
I think it communicates better what's going on.
This error message is also printed when using `bundler/setup` in frozen model, so we're not necessarily installing any gems when it happens. This new message play nicer with all situations.
When a top level dependency is missing from the lockfile, and we're in frozen mode, we should also print a "frozen error".
deivid-rodriguez
force-pushed
the
improve-error-message-in-frozen-mode
branch
from
b7d535b
to
3e82b83
Compare
deivid-rodriguez
added a commit
that referenced
this pull request
Jun 27, 2023
…n-mode Improve edge case error message (cherry picked from commit c13621a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When the lockfile is missing some specs, and we are in frozen mode, we'll get a confusing error such as:
Confusing because
tzinfo-datais actually available at rubygems.org.What is your fix for the problem, implemented in this PR?
My fix is to make sure that we point at the real culprit: a corrupt lockfile.
Closes #6677.
Make sure the following tasks are checked