Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix failures when the build directory name contains + #6750

Merged
merged 2 commits into from Jun 19, 2023

Conversation

nobu
Copy link
Contributor

@nobu nobu commented Jun 16, 2023

What was the end-user or developer problem that led to this PR?

Fixes #6749.

What is your fix for the problem, implemented in this PR?

  1. Use assert_include instead of assert_match if the expected string doesn't contain regexp metacharacters,
    Or escape the expected string with Regexp.quote.
  2. Skip @tempdir contains +.

Make sure the following tasks are checked

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hsbt hsbt merged commit 8f3b4f7 into rubygems:master Jun 19, 2023
83 checks passed
@nobu nobu deleted the path_with_plus branch March 24, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests fail when the build directory name contains +
3 participants