Small refactors for Gem::Resolver
#6766
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simi
approved these changes
Jun 26, 2023
segiddins
reviewed
Jun 27, 2023
| @@ -38,8 +38,6 @@ class Gem::Resolver | |||
| ## | |||
| # List of dependencies that could not be found in the configured sources. | |||
There was a problem hiding this comment.
This comment should also be removed, since it was the documentation for #missing
hsbt
added a commit
that referenced
this pull request
Jun 27, 2023
matzbot
pushed a commit
to ruby/ruby
that referenced
this pull request
Jun 27, 2023
deivid-rodriguez
changed the title
Gem::Resolver
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Gem::Resolverhave some of unused or unnecessary variables.What is your fix for the problem, implemented in this PR?
I removed them.
@missingis unused variable in RubyGems.Molinillo::Resolver#resolveis instance ofMolinillo::DependencyGraph. So, we don't need to pass it fromGem::Resolver.Make sure the following tasks are checked