Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate Gem::Platform.match? #6783

Merged
merged 1 commit into from Jul 21, 2023
Merged

Deprecate Gem::Platform.match? #6783

merged 1 commit into from Jul 21, 2023

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jun 30, 2023

What was the end-user or developer problem that led to this PR?

This is extracted from #6238. We should deprecate Gem::Platform.match? because this method is ambiguous name.

What is your fix for the problem, implemented in this PR?

I marked Gem::Platform.match? as deprecate status.

Make sure the following tasks are checked

Copy link
Member

@deivid-rodriguez deivid-rodriguez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will cause very noisy warnings when using Bundler 2.1.4 with latest RubyGems.

I believe that's fine, Bundler 2.1.4 is from 3 and a half years ago, but I thought it was worth calling that out in case we want to wait a bit more for this.

@hsbt hsbt merged commit 56ba472 into master Jul 21, 2023
83 checks passed
@hsbt hsbt deleted the deprecate-match branch July 21, 2023 08:47
@deivid-rodriguez deivid-rodriguez changed the title Deprecate Gem::Platform.match? Deprecate Gem::Platform.match? Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants