Fix another incorrect removal of "ruby" platform from lockfile when changing path sources #6784
+47
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When dependencies in path sources have changed, we'll be re-resolving, and we can't really know whether the resolution will be valid or invalid for the Ruby platform, so skip the removal in that case.
simi
approved these changes
Jul 2, 2023
deivid-rodriguez
pushed a commit
that referenced
this pull request
Jul 6, 2023
…m-removal Fix another incorrect removal of "ruby" platform from lockfile when changing path sources (cherry picked from commit 84b288c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
When dependencies in path sources have changed, and lockfile includes the RUBY platform among others, we'll incorrectly remove the RUBY platform.
What is your fix for the problem, implemented in this PR?
In this case, we'll be re-resolving, and we can't really know whether the resolution will be valid or invalid for the Ruby platform, so skip the removal in that case.
This is very similar to a previous bug fix and I think it's the last bug fix in preparation for Universal lockfiles, which I expect to finish up very soon!
Make sure the following tasks are checked