Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extract Base64.encode64 method into test case #6797

Merged
merged 1 commit into from Jul 6, 2023
Merged

Conversation

hsbt
Copy link
Member

@hsbt hsbt commented Jul 6, 2023

What was the end-user or developer problem that led to this PR?

I have a plan to promote base64 as bundled gems at ruby/ruby. see https://bugs.ruby-lang.org/issues/19351

After that, the test suite of rubygems is broken because it couldn't load base64. So, we need to avoid to use Base64 library at our tests.

What is your fix for the problem, implemented in this PR?

Base64.encode64 is simple pure ruby method. I ported it to test_gem_request.rb.

Make sure the following tasks are checked

@simi
Copy link
Member

simi commented Jul 6, 2023

Would be an alternative to add base64 gem into test Gemfile?

@hsbt
Copy link
Member Author

hsbt commented Jul 6, 2023

Would be an alternative to add base64 gem into test Gemfile?

Yes, but It's only for this repository. rubygems tests of ruby/ruby repository is failed after extracting base64 from its repository.

@hsbt hsbt enabled auto-merge July 6, 2023 03:56
@hsbt hsbt merged commit fd99c33 into master Jul 6, 2023
83 checks passed
@hsbt hsbt deleted the extract-base64-library branch July 6, 2023 05:01
deivid-rodriguez pushed a commit that referenced this pull request Jul 12, 2023
Extract `Base64.encode64` method into test case

(cherry picked from commit fd99c33)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants