Ensure that loading multiple gemspecs with legacy YAML class references does not warn #6889
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…es does not warn Before this, you would get constant redefinition warnings on Psych::DefaultKey Additionally, ensure the retries wont continue infinitely in the case of the ArgumentError not being caused by Marshal trying to load the undefined classes
For ruby-core compat
deivid-rodriguez
approved these changes
Aug 18, 2023
Co-authored-by: David Rodríguez <deivid.rodriguez@riseup.net>
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
…-yaml-warnings Ensure that loading multiple gemspecs with legacy YAML class references does not warn (cherry picked from commit ee65a1d)
deivid-rodriguez
pushed a commit
that referenced
this pull request
Sep 21, 2023
…-yaml-warnings Ensure that loading multiple gemspecs with legacy YAML class references does not warn (cherry picked from commit ee65a1d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this, you would get constant redefinition warnings on Psych::DefaultKey
Additionally, ensure the retries wont continue infinitely in the case of the ArgumentError not being caused by Marshal trying to load the undefined classes
What was the end-user or developer problem that led to this PR?
I was getting many constant redefinition warnings when attempting to load every gemspec on RubyGems.org in a single process
What is your fix for the problem, implemented in this PR?
Check for constants before defining them
Make sure the following tasks are checked