Fix NoMethodError when choosing a too big number from gem uni
list
#6901
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was the end-user or developer problem that led to this PR?
Executing
gem uni somegem
and choosing a very big number that is not in the list (e.g. choosing5
from thegem uni rails
list where having only 2 rails version being installed) causes the following error:This happens since abacb0c by @nobu where
choose_from_list
has been changed to returnnil
index when an out-of-bound number was chosen (it used to simply return the chosen index regardless of the list size), and so this error can be reproduced on either rubygems v3.4.18, v3.4.19, and 3.5.0.dev as of today.What is your fix for the problem, implemented in this PR?
Just added a
nil
check before using the index value in Uninstaller#uninstall.I skipped adding a reproduction test for this case because I couldn't find a good place to write such an integrated combination test of the ui and the command while unit test for each of them exist independently.
Make sure the following tasks are checked